Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Node 22 #214

Merged
merged 7 commits into from
Jan 15, 2025
Merged

feat: Upgrade to Node 22 #214

merged 7 commits into from
Jan 15, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 10, 2025

This pull request includes significant updates to dependencies, refactoring of the main application setup, and removal of several plugins. The most important changes involve updating dependencies in package.json, refactoring src/app.js to use the latest probot setup, and removing multiple plugins that are no longer needed.

Note: I couldn't figure out how to run the bot locally to ensure it will start.

Fixes #205

Dependency Updates:

  • Updated moment to version ^2.30.1, moment-timezone to ^0.5.46, probot to ^13.4.1, and added @octokit/rest as a new dependency. (package.json: package.jsonL25-R37)
  • Updated jest to version ^29.7.0 and nock to ^13.5.6. (package.json: package.jsonL25-R37)
  • Changed the required Node.js version to 22.x. (package.json: package.jsonL58-R59)

Application Setup Refactoring:

  • Refactored src/app.js to use the latest Probot setup, including new type definitions and updated initialization code. (src/app.js: [1] [2] [3]

Plugin Removals:

Minor Refactoring:

  • Updated type definitions and variable names in the commit-message plugin for consistency with the new Probot setup. (src/plugins/commit-message/index.js: [1] [2] [3] [4] [5] [6]

@nzakas nzakas marked this pull request as draft January 10, 2025 23:10
@nzakas nzakas marked this pull request as ready for review January 13, 2025 17:37
package.json Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving it open if anyone else wants to take a look, or feel free to merge when appropriate.

@nzakas nzakas merged commit 3461ecf into main Jan 15, 2025
3 checks passed
@nzakas nzakas deleted the node20 branch January 15, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot needs updating to be deployed
2 participants